Skip to content

feat(describe): prompt user when no function name provided #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(describe): prompt user when no function name provided #3092

wants to merge 1 commit into from

Conversation

@intojhanurag
Copy link
Contributor

@intojhanurag intojhanurag commented Oct 15, 2025 •
edited
Loading

This PR enhances the func describe command by adding an interactive prompt that asks the user to enter a function name when it is not provided as a command argument.

Before

Screenshot 2025-10-17 013005

After

Screenshot 2025-10-17 012926

@knative-prow
Copy link

knative-prow bot commented Oct 15, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2025
@knative-prow knative-prow bot requested review from jrangelramos and nainaz October 15, 2025 06:20
@knative-prow
Copy link

knative-prow bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: intojhanurag
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.89%. Comparing base (86062c2) to head (0cdd5cd).
⚠️ Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
cmd/describe.go 0.00% 30 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (86062c2) and HEAD (0cdd5cd). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (86062c2) HEAD (0cdd5cd)
1 0
unit-tests 3 0
e2e-tests 2 1
integration-tests 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #3092       +/-   ##
===========================================
- Coverage   58.41%   30.89%   -27.53%     
===========================================
  Files         134      117       -17     
  Lines       17263    16790      -473     
===========================================
- Hits        10085     5187     -4898     
- Misses       6246    10983     +4737     
+ Partials      932      620      -312
Flag Coverage Δ
e2e-tests 30.89% <0.00%> (-8.13%) ⬇️
integration-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2025
@intojhanurag
Copy link
Contributor Author

Hey @gauron99, I’m just curious, why is it asking for the function name even when no prompt was declared?
The TODO mentioned adding a prompt section to describe the function name.

@gauron99
Copy link
Contributor

gauron99 commented Oct 16, 2025 •
edited
Loading

not sure if I entirely understand what youre saying, but when you run func describe by itself in an empty dir (no function) it doesnt ask you anything because the prompt is not implemented; it just fails. Same as you found the //TODO in the test, there is one (equivalent) todo in the runDescribe function itself so once that is in place, the TODO indicates that this is where you would test it as well.

So this test addition you implemented is only 50% of the intended change, you still need the actual implementation itself 😄

@intojhanurag
Copy link
Contributor Author

Thanks @gauron99 , I was a bit confused earlier.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2025
@gauron99
Copy link
Contributor

/retest

@knative-prow
Copy link

knative-prow bot commented Oct 20, 2025

@intojhanurag: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_func_main 0cdd5cd link true /test unit-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@nainaz nainaz Awaiting requested review from nainaz

Assignees

No one assigned

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@intojhanurag @gauron99